GOSSIP-11: introducing junit5

This commit is contained in:
chandresh-pancholi
2016-09-09 21:16:07 +05:30
parent 4e13c899f0
commit 316e8e752d
5 changed files with 31 additions and 19 deletions

10
pom.xml
View File

@ -78,12 +78,14 @@
<artifactId>jackson-datatype-json-org</artifactId> <artifactId>jackson-datatype-json-org</artifactId>
<version>${jackson-datatype-json-org.version}</version> <version>${jackson-datatype-json-org.version}</version>
</dependency> </dependency>
<dependency> <dependency>
<groupId>junit</groupId> <groupId>org.junit.jupiter</groupId>
<artifactId>junit</artifactId> <artifactId>junit-jupiter-api</artifactId>
<version>${junit.version}</version> <version>5.0.0-M2</version>
<scope>test</scope>
</dependency> </dependency>
<dependency> <dependency>
<groupId>io.teknek</groupId> <groupId>io.teknek</groupId>
<artifactId>tunit</artifactId> <artifactId>tunit</artifactId>

View File

@ -31,10 +31,10 @@ import java.util.concurrent.TimeUnit;
import org.apache.log4j.Logger; import org.apache.log4j.Logger;
import org.junit.Test;
import org.apache.gossip.event.GossipListener; import org.apache.gossip.event.GossipListener;
import org.apache.gossip.event.GossipState; import org.apache.gossip.event.GossipState;
import org.junit.jupiter.api.Test;
public class ShutdownDeadtimeTest { public class ShutdownDeadtimeTest {

View File

@ -19,9 +19,9 @@ package org.apache.gossip;
import org.apache.log4j.Logger; import org.apache.log4j.Logger;
import org.json.JSONException; import org.json.JSONException;
import org.junit.Test;
import io.teknek.tunit.TUnit; import io.teknek.tunit.TUnit;
import org.junit.jupiter.api.Test;
import java.io.File; import java.io.File;
import java.io.FileOutputStream; import java.io.FileOutputStream;

View File

@ -30,10 +30,10 @@ import java.util.concurrent.TimeUnit;
import org.apache.log4j.Logger; import org.apache.log4j.Logger;
import org.junit.Test;
import org.apache.gossip.event.GossipListener; import org.apache.gossip.event.GossipListener;
import org.apache.gossip.event.GossipState; import org.apache.gossip.event.GossipState;
import org.junit.jupiter.api.Test;
public class TenNodeThreeSeedTest { public class TenNodeThreeSeedTest {
private static final Logger log = Logger.getLogger( TenNodeThreeSeedTest.class ); private static final Logger log = Logger.getLogger( TenNodeThreeSeedTest.class );

View File

@ -23,8 +23,7 @@ import org.apache.gossip.LocalGossipMember;
import org.apache.gossip.event.GossipListener; import org.apache.gossip.event.GossipListener;
import org.apache.gossip.event.GossipState; import org.apache.gossip.event.GossipState;
import org.apache.gossip.manager.random.RandomGossipManager; import org.apache.gossip.manager.random.RandomGossipManager;
import org.junit.Assert; import org.junit.jupiter.api.Test;
import org.junit.Test;
import javax.management.Notification; import javax.management.Notification;
import javax.management.NotificationListener; import javax.management.NotificationListener;
@ -34,6 +33,11 @@ import java.net.URISyntaxException;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.List; import java.util.List;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.expectThrows;
public class RandomGossipManagerBuilderTest { public class RandomGossipManagerBuilderTest {
public static class TestGossipListener implements GossipListener { public static class TestGossipListener implements GossipListener {
@ -50,21 +54,27 @@ public class RandomGossipManagerBuilderTest {
} }
} }
@Test(expected=IllegalArgumentException.class) @Test
public void idShouldNotBeNull() { public void idShouldNotBeNull() {
RandomGossipManager.newBuilder().cluster("aCluster").build(); expectThrows(IllegalArgumentException.class,() -> {
RandomGossipManager.newBuilder().cluster("aCluster").build();
});
} }
@Test(expected=IllegalArgumentException.class) @Test
public void clusterShouldNotBeNull() { public void clusterShouldNotBeNull() {
RandomGossipManager.newBuilder().withId("id").build(); expectThrows(IllegalArgumentException.class,() -> {
RandomGossipManager.newBuilder().withId("id").build();
});
} }
@Test(expected=IllegalArgumentException.class) @Test
public void settingsShouldNotBeNull() { public void settingsShouldNotBeNull() {
RandomGossipManager.newBuilder().withId("id").cluster("aCluster").build(); expectThrows(IllegalArgumentException.class,() -> {
} RandomGossipManager.newBuilder().withId("id").cluster("aCluster").build();
});
}
@Test @Test
public void createMembersListIfNull() throws URISyntaxException { public void createMembersListIfNull() throws URISyntaxException {
RandomGossipManager gossipManager = RandomGossipManager.newBuilder() RandomGossipManager gossipManager = RandomGossipManager.newBuilder()
@ -74,7 +84,7 @@ public class RandomGossipManagerBuilderTest {
.settings(new GossipSettings()) .settings(new GossipSettings())
.gossipMembers(null).build(); .gossipMembers(null).build();
Assert.assertNotNull(gossipManager.getLiveMembers()); assertNotNull(gossipManager.getLiveMembers());
} }
@Test @Test
@ -89,8 +99,8 @@ public class RandomGossipManagerBuilderTest {
.settings(new GossipSettings()) .settings(new GossipSettings())
.uri(new URI("udp://localhost:8000")) .uri(new URI("udp://localhost:8000"))
.gossipMembers(memberList).build(); .gossipMembers(memberList).build();
Assert.assertEquals(1, gossipManager.getLiveMembers().size()); assertEquals(1, gossipManager.getLiveMembers().size());
Assert.assertEquals(member.getId(), gossipManager.getLiveMembers().get(0).getId()); assertEquals(member.getId(), gossipManager.getLiveMembers().get(0).getId());
} }
} }